chore: Use published router-bridge#1613
Conversation
part of #491 We have published the `router-bridge` to crates.io, which removes the need for router developers to have nodejs installed.
Remove nodejs from the CI steps.
…er into igni/published_bridge
o0Ignition0o
requested review from
Geal,
SimonSapin,
abernix and
garypen
and removed request for
abernix and
garypen
| name: cargo check workspace | ||
| command: | | ||
| set -e -o pipefail | ||
| cargo check --locked |
There was a problem hiding this comment.
Isn't this redundant with the build that's necessary for running tests?
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash | ||
| echo '. ~/.nvm/nvm.sh' >> $BASH_ENV | ||
| - run: | ||
| name: Install desired Node.js version |
There was a problem hiding this comment.
Very nice to be able to remove all this!
Does this mean we can get rid of the ASDF stuff in our repo as well now? |
|
| @@ -1,5 +0,0 @@ | |||
| # If updating this, you *must* also change the channel in rust-toolchain.toml | |||
| # renovate-automation: rustc version | |||
| rust 1.61.0 | |||
There was a problem hiding this comment.
@o0Ignition0o Curious — this PR was intended to remove the dependency on Node.js, which was indeed great, but I'm curious why you chose to remove rust from .tool-versions as well? Would we consider adding it back? Do we think it's unnecessary?
There was a problem hiding this comment.
As far as I know .tool-versions is only used by ASDF. In my experience folks writing Rust regularly have $(which cargo) pointing to rustup, not ASDF. With this PR, ASDF is not needed at all to contribute to the Router.
5 participants
part of #491
We have published the
router-bridgeto crates.io, which removes the need for router developers to have nodejs installed.